Yours is bugged. It looks at the outer $_ in all those ref calls. Just happens to work.
Here's a non-recursive version:
sub mychomp {
while (@_) {
eval { chomp $_[0] }, shift, next unless ref;
(push @_, @{shift @_}), next if ref $_[0] eq 'ARRAY';
(push @_, values %{shift @_}), next if ref $_[0] eq 'HASH';
shift;
}
}
-- Randal L. Schwartz, Perl hacker
update:
I didn't claim it was a working version. Thanks for the updates in the thread. {grin}
Also, I didn't see the unusual multi-line backwards-for in the original code, so it appears to be less buggy than I thought. {sigh}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|