Beefy Boxes and Bandwidth Generously Provided by pair Networks
Come for the quick hacks, stay for the epiphanies.
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
Short of going to a completely different hash implementation, there are incremental improvements you can make to improve your code... You can factor out the indexing operations: Instead of
if ( ($genome[$i] eq 'a') && ($genome[$i+1] eq 'a')) { ++$tt; } elsif ( ($genome[$i] eq 'a') && ($genome[$i+1] eq 'g')) { ++$ag; } elsif ( ($genome[$i] eq 'a') && ($genome[$i+1] eq 'c')) { ++$ac; } elsif ( ($genome[$i] eq 'a') && ($genome[$i+1] eq 't')) { ++$at; } elsif ( ($genome[$i] eq 't') && ($genome[$i+1] eq 'a')) { ++$ta; } ...
use...
my $genome = $genome[$i]; my $genome1 = $genome[$i+1]; if ( ($genome eq 'a') && ($genome1 eq 'a')) { ++$tt; } elsif ( ($genome eq 'a') && ($genome1 eq 'g')) { ++$ag; } elsif ( ($genome eq 'a') && ($genome1 eq 'c')) { ++$ac; } elsif ( ($genome eq 'a') && ($genome1 eq 't')) { ++$at; } elsif ( ($genome eq 't') && ($genome1 eq 'a')) { ++$ta; } ...
Finding the array elements is done only once, rather than once per comparison. The next improvement would be to concatenate the two elements and halve the number of comparisons try...
my $genomepair = $genome[$i] . $genome[$i+1]; if ( $genomepair eq 'aa' ) { ++$tt; } elsif ( $genomepair eq 'ag') { ++$ag; } elsif ( $genomepair eq 'ac') { ++$ac; } elsif ( $genomepair eq 'at') { ++$at; } elsif ( $genomepair eq 'ta') { ++$ta; } ...

In reply to A less extreme change.. by TravelByRoad
in thread how can I speed up this perl?? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others meditating upon the Monastery: (2)
As of 2024-04-16 14:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found