comment on

I think that use of wantarray() to modify return behavior should be generally avoided. In my opinion it is a clear violation of the principal of least surprise.

As an example, consider this real-world case from Bricolage:

  @stories = Bric::Biz::Asset::Business::Story->list();
  if (not @stories) {
     print "There are no stories.\n";
  }
[download]

That works fine, but this doesn't:

  if (not Bric::Biz::Asset::Business::Story->list()) {
     print "There are no stories.\n";
  }
[download]

That's because Bricolage list() methods (and lots of other Bricolage methods) try to be helpful and return array refs in scalar context. I've personally found a number of bugs that turned out to be caused by this problem, and I'm sure there are more waiting to be found.

There may be cases where wantarray() is useful, but I definitely don't consider it a general-purpose tool.

-sam

In reply to Re: What should be returned in scalar context? by samtregar
in thread What should be returned in scalar context? by tilly

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Don't ask to ask, just ask
	PerlMonks