comment on

Sorry if this is a bit late, FWIW...

1) Most of the replies published (well, those that work :-) truncate strings that are exactly of the desired length, while your original version keeps these intact. Test case:

my $str = trim_length ( 'this sentence is 30 signs long', 30 );

If you use eg BrowserUK's code, this is easy to fix: just change

return $str if length $str < $n;

to:

return $str if length $str <= $n;

2) It might be an idea to strip off trailing whitespace, in order to avoid adding ' ...' to the end of a message that is essentially complete. My own solution, again FWIW, would be

sub trim_length {
   my ( $str, $desired_len ) = @_;
   $str =~ s/\s+$//; # Strip trailing whitespace
   return $str if length $str <= $desired_len;
   return sprintf "%.${desired_len}s ...", 
      substr $str, 0, ( rindex $str, ' ', $desired_len );
}
[download]

dave

In reply to Re: In search of a better way to trim string by Not_a_Number
in thread In search of a better way to trim string by kiat

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Pathologically Eclectic Rubbish Lister
	PerlMonks