How about
my $country = uc $card->country || ''; # make sure it is UC and define
+d
$country = '' if $country eq 'GBR'; # blat the Brits
Same caveat about hard coded GBR still applies. It is still brief but I think the logic is clearer so divided. I am aware that will kill $country == 0 but as you are checking for gbr I suspect you do not have numeric countries
update
I missed the addition of [] around the country (sort of proves the danger of too much on one line) so my solution needs another line
$country = "[$country]" if $country;
or a re-write, I will put my thinking hat back on again !
update 2
with inspiration from perrin
my $def_country = 'GBR'
my $country = uc $card->country || $def_country; # ensure UC & has a v
+alue
$country = $country eq 'GBR' ? '' : "[$country]" # blat brits, add [br
+ackets]
Cheers, R.
Pereant, qui ante nos nostra dixerunt!
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|