I would write that as
my @images = ( [], [] );
{
my( @imgstr ) = split /\|/, $str, 2;
@{ $images[0] } = $imgstr[0] =~ m/(\w+\.jpg)/gi;
@{ $images[1] } = $imgstr[1] =~ m/(\w+\.jpg)/gi;
}
because
- using parens with built-in functions is ugly , extra typing
-
split takes regex as 1st argument, and you're only expecting it to return 2 parts at most
- avoid slice syntax when you're not taking a slice ($images[0])
- avoid pretend arrays, use real arrays (@imgstr)
- limit scope of temporary variables
Actually I would write
my @images;
{
my @imgstr = split /\|/, $str, 2;
push @images, [ $_ =~ m/(\w+\.jpg)/gi ] for @imgstr;
}
or actually
my @images = map { [ $_ =~ m/(\w+\.jpg)/gi ] } split /\|/, $str;
Yes, the last one is how I would normally write something like that, its funny how digesting someone else s code plays tricks on you :)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|