comment on

Your small code sample has no violations using the default settings on Perl::Critic. However, you can turn up the severity, and start to get complaints. I am more familiar with the perlcritic command line tool:

$ perlcritic -1 critic
Code is not tidy at line 1, column 1.  See page 33 of PBP.  (Severity:
+ 1)
Use Emacs file variables to declare coding style at line 1, column 1. 
+ Emacs can read per-file settings.  (Severity: 2)
RCS keywords $Id$ not found at line 1, column 1.  See page 441 of PBP.
+  (Severity: 2)
RCS keywords $Revision$, $HeadURL$, $Date$ not found at line 1, column
+ 1.  See page 441 of PBP.  (Severity: 2)
RCS keywords $Revision$, $Source$, $Date$ not found at line 1, column 
+1.  See page 441 of PBP.  (Severity: 2)
Missing Perl version at line 1, column 1.  Add "use 5.006" or similar.
+  (Severity: 1)
No package-scoped "$VERSION" variable found at line 1, column 1.  See 
+page 404 of PBP.  (Severity: 2)
Return value of flagged function ignored - print at line 11, column 1.
+  See pages 208,278 of PBP.  (Severity: 1)
[download]

Your results may vary depending on the version of Perl::Critic (I also have additional policies loaded on my system).

UPDATE: Why didn't you pass a filename on the command line to your critic program? $file has not been assigned a value.

Also, to set the severity in your critic program:

my $critic = Perl::Critic->new(-severity=>1);
[download]

In reply to Re^3: perlcritic & test files by toolic
in thread perlcritic & test files by Bor

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Think about Loose Coupling
	PerlMonks