Re^2: Peer Review For Perl Code

[particle]

in reply to Re: Peer Review For Perl Code
in thread Peer Review For Perl Code

These reviews for the Attempt module make me question the validity of all code reviews. How could you give a perfect rating to a module that only saves a few keystrokes of simple code, if any? What kind of programmer would have trouble creating Attempt's functionality within their own code? I'd never use a module like that, and I can't believe it was recommended to me and it hasn't received anything but perfect ratings.

well, i saw those (two) reviews, and i agreed with you. so, i put my own code review up. and--this is critical--i looked at the code. i found two bugs, so i entered a rt ticket, which will be forwarded to the module author. i will use this code. it is consise, and i find it extends the language in a way that makes my coding easier. also, this code has gone through code reviews, and has been tested by users. are you sure your code is right? how many users have reviewed your code?

working as a lone wolf consultant, and using perl in companies where there is not wide adoption of the language, i rely heavily on code that has been written, reviewed, and tested by others, namely that found on the CPAN. code reviews are valid, some are more valid than others--if you think otherwise, perhaps you should think some more about it.

if you're so critical, why don't you take the time to post a fair review? put up, or shut up. i did.

[Wassercrats]

I was thinking of reviewing it, but I was afraid Attempt was more useful than I thought. I want something similar for:

      # Create a user agent object
      use LWP::UserAgent;
      $ua = LWP::UserAgent->new;

      # Create a request
      my $req = HTTP::Request->new(GET => "$VarHere[0]");

      # Pass request to user agent. Get a response back.
      my $res = $ua->request($req);

      # Check outcome of response
      if ($res->is_success)
      {
         $_ = $res->content;
      }
      else
      {
         whatever
      }

And I figured a simple while and sleep could do the same thing with the same amount of code and eliminate all the code from the module. I see no point to the module at all, but I still have a feeling I'm missing something, so I won't be reviewing it. Yet.

(I'd need a counter too. Big deal)