Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw

Re^3: Counting In a Log File from Multiple Variables

by Rhose (Priest)
on Sep 02, 2004 at 19:48 UTC ( #388071=note: print w/replies, xml ) Need Help??

in reply to Re^2: Counting In a Log File from Multiple Variables
in thread Counting In a Log File from Multiple Variables

I would change:

while(<FILE>) { # chomp; #@_=split(','); foreach $line (<FILE>) { @_=split(','); $Data->{$_[1]}->{$_[3]}++; } }


while(<FILE>) { chomp; @_=split(','); $Data->{$_[1]}->{$_[3]}++; }

The "chomp" will get rid of that pesky newline you are seeing in the output. Also, the "while(<FILE>)" will process each line of your file (one at a time) and will assign each line to $_. This means your "foreach $line (<FILE>)" is not needed.

Note: The foreach loop in your code would assign data to the $line variable. Your split is splitting $_ (nothing specified mean you get to use the default $_)... if you were to use your foreach, you would want to change your split to "@_=split(',',$line);"

Replies are listed 'Best First'.
Re^4: Counting In a Log File from Multiple Variables
by monger (Friar) on Sep 03, 2004 at 13:20 UTC
    Thanks Rhose. Worked like a charm. Now to look at expanding to count some more fields. Now my feet are a bit wetter, I think I'm in business! monger
    Monger +++++++++++++++++++++++++ Munging Perl on the side

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://388071]
[1nickt]: I think it is indubitably fast. But it's not a drop in replacement. And I tend to be leery of putting too many eggs in these one-man baskets.
[LanX]: interesting the author doesn't seem to accept javascript as a scripting language
[LanX]: ... and calls php7 the winner oO

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (5)
As of 2017-05-22 20:35 GMT
Find Nodes?
    Voting Booth?