Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

Re: Global variable vs passing variable from sub to sub

by Ovid (Cardinal)
on Sep 13, 2004 at 16:32 UTC ( #390597=note: print w/replies, xml ) Need Help??

in reply to Global variable vs passing variable from sub to sub

Consider the following snippet:

sub account_over_limit { my ($account, $balance) = @_; return exists $LIMITED_ACCOUNTS{$account} && $balance > $LIMIT; }

You might think that since the %LIMITED_ACCOUNT and $LIMIT variables are relatively static, declaring them as globals is a good idea. In reality, this makes life very difficult if you need to refactor the code or track down bugs. Obviously, you now have a routine that cannot be cut and pasted into another package as part of a refactoring strategy because you're dependent on external data. This is a big problem.

Next, consider what happens when you realize that different accounts have different limits. Your code changes $LIMIT at one point and forgets to reset it. Now your &account_over_limit subroutine returns spurious results, but this problem might not show up for weeks until your accounting department realizes that some people have received more credit than they should, or are complaining when they're not allowed to buy something.


New address of my CGI Course.

Replies are listed 'Best First'.
Re^2: Global variable vs passing variable from sub to sub
by kiat (Vicar) on Sep 13, 2004 at 16:38 UTC
    Thanks for your very specific example, Ovid!

    I do have things like that in my code but they are kept to the minimal.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://390597]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others surveying the Monastery: (10)
As of 2016-10-28 21:16 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (387 votes). Check out past polls.