Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re^2: Triangle Numbers Revisited

by Limbic~Region (Chancellor)
on Oct 14, 2004 at 11:29 UTC ( #399166=note: print w/replies, xml ) Need Help??

in reply to Re: Triangle Numbers Revisited
in thread Triangle Numbers Revisited

This is blazingly fast...

I wanted to see just how fast, so I modified your code to fit into the benchmark FoxtrotUniform and I were playing with. It turns out your code is only about half as fast as my second version and it has a bug I didn't bother to track down. To see the bug, try entering 3133756 with your code.

I say your code is only about half as fast because it got less than halfway through (line 2235 of 5000) when it blew up and it took approximately the same amount of time (3.619 seconds) to get there.

In case you want to run some more tests yourself, take a look at and then use this modified code:

#!/usr/bin/perl use strict; use warnings; my ($i, $j, $inum, $jnum, $left); my $file = $ARGV[0] || 'targets.txt'; open (INPUT, '<', $file) or die "Unable to open $file for reading : $! +"; while ( chomp( my $inp = <INPUT> ) ) { BING: for ($i = tget($inp); $i; $i--) { $inum = tmake($i); $left = tget($inp - $inum - 1) + 1; for ($j = 1; $j < $left; $j++) { $jnum = tmake($j); last BING if (tis($inp - $inum - $jnum)); } } } sub tget { return int(sqrt(1 + $_[0] * 2) - .5); } sub tmake { return (.5 * $_[0] * ($_[0] + 1)); } sub tis { my $n = shift; return ($n == tmake(tget($n))); }

Cheers - L~R

Replies are listed 'Best First'.
Re^3: Triangle Numbers Revisited
by TedPride (Priest) on Oct 14, 2004 at 11:52 UTC
    I found and fixed the bug. See my second version. As to it being blazingly fast, it is blazingly fast - just not as blazingly fast as it could be if I took the time to optimize the algorithm. Congrats if yours is faster.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://399166]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others avoiding work at the Monastery: (5)
As of 2018-05-23 17:31 GMT
Find Nodes?
    Voting Booth?