Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid

Re: Quoting in DBI sql query for on the fly query

by htoug (Deacon)
on Oct 29, 2004 at 12:01 UTC ( #403699=note: print w/replies, xml ) Need Help??

in reply to Quoting in DBI sql query for on the fly query

In your second example the terminating " is missing.

You should use $dbh->quote($line) to ensure that the quoting is correct. This incidentally guards against SQL-injection attacks. You need a chomp to remove the trailing newline in $line

You should write something like (untested):

my @lines = <DATA>; my $line; foreach $line ( @lines ) { chomp($line); #prepare and execute SQL statement $sqlstatement="SELECT Table1.Name, Table1.Address, Table1.City, Table1.State, Table1.ZIP, Table1.Phone FROM Table1 WHERE Table1.BusType = ".$dbh->quote($l +ine); $sth = $dbh->prepare($sqlstatement); }

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://403699]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (4)
As of 2017-07-27 22:43 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (422 votes). Check out past polls.