Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re^3: A new chatterbox flavour

by The Mad Hatter (Priest)
on Dec 19, 2004 at 16:16 UTC ( #415997=note: print w/ replies, xml ) Need Help??


in reply to Re^2: A new chatterbox flavour
in thread A new chatterbox flavour

Good point. I hadn't really studied it much other than looking for where the login "failed" for me.


Comment on Re^3: A new chatterbox flavour
Replies are listed 'Best First'.
Re^4: A new chatterbox flavour
by Aristotle (Chancellor) on Dec 19, 2004 at 16:41 UTC

    But then I forgot to re-escape the cookie… patch and root node updated.

    Makeshifts last the longest.

      And it's still broken. :-)

      I just got around to using your updated version instead of my hackery, and noticed it didn't work. Here's a fix:

      --- pmchat.html.old 2004-12-19 20:12:15.000000000 -0500 +++ pmchat.html 2004-12-19 20:07:59.000000000 -0500 @@ -15,7 +15,7 @@ var record = str.split( /\s*;\s*/ ); for( var i = 0; i < record.length; ++i ) { var kv = record[ i ].split( /=/ ); - this.data[ decodeURIComponent( kv[ 0 ] ) ] = d +ecodeURIComponent( kv[ 1 ] ); + this.data[ decodeURIComponent( kv[ 0 ].replace +(/%25/g, '%') ) ] = decodeURIComponent( kv[ 1 ].replace(/%25/g, '%') +); } }, get: function( key ) {
      PM seems to double-encode or something -- at the least, percents (%) are replaced with %25 in the already URL encoded string. It doesn't seem to care if you do the reverse or not when re-encoding it.

        There are more doubly encoded characters than just that one. PM's cookie is weird… In any case, I did this to fix it instead:

        --- pmchatter.html.old 2004-12-20 02:49:00.000000000 +0100 +++ pmchatter.html 2004-12-20 02:49:03.000000000 +0100 @@ -34,3 +34,3 @@ - try{ cookie.parse( this.req.getResponseHeader( 'Set-Co +okie' ) ); } + try{ decodeURIComponent( cookie.parse( this.req.getRes +ponseHeader( 'Set-Cookie' ) ) ); } catch( e ) { }

        Makeshifts last the longest.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://415997]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (15)
As of 2015-07-28 20:12 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (258 votes), past polls