#!/usr/bin/perl -w
use strict;

my $dir = "/home/my/files";
chdir $dir or die "can't chdir $dir: $!";

my $i;
do { rename $_, ++$i . "-$_" or die "can't rename: $!" } for glob "*";
[download]

Will break on directories with more than 999 files. But so will your original. :)

(This is not meant to be golf, by the way. "I'm not saying I'd code it this way, but I'm not saying I wouldn't", to paraphrase $SOMEONE_SMARTER_THAN_ME (whose identity I forget.))

Many thanks for reply.
Of cource yours code works very good, but - it's my fault, I didn't wrote it - makes 1-file, 2-file, 3-file... etc and I was thinking about 001-file, 002-file, 003-file ...

regards,
Ukasza

Ooops, somehow I omitted this from the version I posted. Just make this change:

my $i;

# change to

my $i = '000';
[download]

#!/usr/bin/perl
use strict;
use warnings;

my $dir = "/home/my/files" ;
chdir $dir or die "$!";
opendir(DIR,$dir ) or die "$!";
my $i = 1;

for (grep { !/^\./ } readdir(DIR)) {
    rename $_,sprintf ('%03d-%s',$i++,$_) or warn "Couldn't rename $_:
+ $!";
}
[download]

I think you may be trying too hard to use perlisms (like the regexp replace). Often, it's better to just look for simpler ways to do things.

But I'm dreaming about myself as Great_Saint_YAPH_Perl_Lover ;-))

As a "one-liner" (with caveats), this would do the trick:

perl -wle "$x='000'; $x++ and $o=$_ and s[/(.*$)][/$x-$1] and rename($
+o,$_) or warn $! for glob qq[$ARGV[0]/*]" dir
[download]

but trying to remember how to type that is too hard, so you'd want to make it a script, at which point your original is much nicer.

For what it's worth, here's how I'd probably have written it (something like this anyhow). I'm not too sure about the glob. I've heard about how it's better to use the opendir/readdir combo, so I'm not too sure what to think of that.

#!perl -w

use strict;

chdir('bar') or die("chdir() failed: $!\n");

my $cnt;

rename( $_, sprintf('%03d-%s', ++$cnt, $_) )
    or warn("rename() failed: $!\n")
        for ( grep { ! /\A\./ } glob('*') );
[download]