SENDMAIL problem!

[Anonymous Monk]

My funtion

sub send_mail {
    my ($send_from,$subject,$message) = @_;
    open(SENDMAIL, "|/usr/sbin/sendmail -oi ")
    or return ("<span class='darkredbold'>Sorry you email coudn't be s
+end. $!</span>"); 
    print SENDMAIL "From: ".$send_from;
    print SENDMAIL "To: aaa\@aaa.com";
    print SENDMAIL "Subject:".$subject;
    print SENDMAIL "\n";
    print SENDMAIL $message;
    close(SENDMAIL) or return ("<span class='darkredbold'>Sorry you em
+ail coudn't be send. $!</span>");
    return("<span class='darkbluebold'>Email sended. Thanks for your o
+pinion.</span>");    
}

Doesn't work!!!

[gellyfish]

Firstly you don't specify how it doesn't work - does it throw an error or simply not send any mail.

Secondly I think you want /usr/sbin/sendmail -oi -t if you are expecting sendmail to parse the recipient address from the headers of the message you feed it.

/J\

[cog]

And exactly how doesn't it work?

[BazB]

Define "doesn't work".

You should avoid using a piped open to sendmail. Try using one of the many modules on CPAN that provide a simple, well tested, abstracted and portable solution, such as Net::SMTP.

[gellyfish]

You should avoid using a piped open to sendmail.

As a matter of interest why? Using the mail injection capabilities of sendmail (or other MTA - most provide a similar interface) is reliable and simple: the MTA will perform all the queuing, error recovery and MX lookup for you whereas with (e.g) Net::SMTP you have to do all of these things for yourself plus you are subject to the exigencies of the networks condition, if a local MTA cannot send a message because the MX host is unreachable then it will try again until it can send it (or the retry times out), if you don't provide this functionality yourself with one of the modules then the message at best won't get sent.

Of course I'm not suggesting that one shouldn't use the modules either, just taking issue with the assertion that they are in all cases superior than using the MTA directly.

This has been done to death over the years and I am sure you can find plenty of arguments and counter arguments in the archives of CLPM.

/J\

[sh1tn]

...
open(SENDMAIL, "|/usr/sbin/sendmail -oi ") 
or 
warn "cannot open pipe $!" and return ("...")
...

[NateTut]

And now a word from the grammar Nazi:

Change:
"Sorry you email coudn't be send."
To:
"Sorry your e-mail couldn't be sent."
And:
"Email sended. Thanks for your opinion."
To:
"Email sent. Thank you for your opinion."


And now back to your regularly scheduled node...

[gellyfish]

I fail to see how that would prevent the program from sending mail :-p

/J\

[NateTut]

It might indeed send mail, but this way the user will clearly know that the mail has been sent, or not!

I'm not trying to bust the OP's chops, English is obviously not his primary language, I'm just trying to help him make his code a bit better.

The Grammer Nazi

P.S. I am HTML challenged, what is the tag for a tab character?

[Anonymous Monk]

Well know it's sending email :)

sub send_mail {
    my ($send_from,$subject,$message) = @_;
    open(SENDMAIL, "|/usr/sbin/sendmail -oi -t")
    or warn "cannot open pipe $!" and return ("<span class='darkredbol
+d'>Sorry you email coudn't be send. $!</span>"); 
  
    print SENDMAIL "From: $send_from \n";
    print SENDMAIL "To: aaa\@aaa.com \n";
    print SENDMAIL "Subject: $subject \n";
    print SENDMAIL "\n";
    print SENDMAIL "$message \n";
    close(SENDMAIL) or return ("<span class='darkredbold'>Sorry you em
+ail coudn't be send. $!</span>");
    return("<span class='darkbluebold'>Email sended.Contact. Thanks fo
+r your opinion.</span>");    
}

i add  \n and change
 print SENDMAIL "From: ".$send_from;
for
print SENDMAIL "From: $send_from \n"; Thanks for the help you guys are great, one more time thanks.

[Anonymous Monk]

"I'm not trying to bust the OP's chops, English is obviously not his primary language, I'm just trying to help him make his code a bit better." And i thank you ;), it's true my primary language isn't english but i thinks that it isn't soo bad :( , ok not perfect ... but with time and practice and with your help it can be better ;)

[NateTut]

I'm sure you speak English better than I speak your language! You manage to communicate your ideas which is the objective after all.

I'm glad you took my suggestions in the spirit in which they were intended.

The Grammar Nazi

[Anonymous Monk]

One more thing, in internet explorer my site is fine, but if i try in Mozilla Firefox, some problems happens, like spaces and stuff like that. Can you give a direction to see the diferences between browsers?

[ww]

You don't indicate you've done so, so you may wish to validate your html against w3c ( html validator ) standards. There's also a .css validator, if you're using stylesheets.
But there are many other questions here: what vers. each browser? how is site hosted (windows, linux, ???? Did you use proper upload mode to prevent *n*x vs. DOS line-ending issues? address of site? description of where (in what page) discrepancies occur?

Point is, you have details that the Monastery does not. We can best help you -- even if no more than offering the likes of my first paragraph -- if we have sufficient info to offer decent help.

And with all that said, why don't you register a name, and join the madness?