Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

Re: To script or not to script, that is the question...

by tilly (Archbishop)
on May 31, 2005 at 17:30 UTC ( #462135=note: print w/replies, xml ) Need Help??


in reply to To script or not to script, that is the question...

The Perl Dr saw a function named Update::update and thought this was fine??

You need that second opinion!

There are a million kinds of updates out there. If I run across a function named update, I have no idea what it does, and I'll curse the person who wrote it with no mercy for the maintainance programmer looking for context.

Please name it something that gives a hint what it does. Something like "update_download" or "make_download_current".

While you're at it, I would leave out the superfluous "return 1". (Are you using that return anywhere?)

  • Comment on Re: To script or not to script, that is the question...

Replies are listed 'Best First'.
Re^2: To script or not to script, that is the question...
by biosysadmin (Deacon) on May 31, 2005 at 22:01 UTC

    I concur with tilly. My diagnosis is that your module needs a more specifically named namespace, and possibly a more illustrative name for your subroutine. Weirdly enough, coming up with a perfect name for a subroutine/package/module sometimes takes me longer than the design login and implementation.

    So, take two rename update's and call us in the morning. :)

Re^2: To script or not to script, that is the question...
by tlm (Prior) on May 31, 2005 at 17:41 UTC

    The return value of Update::update is used by the calling code to decide whether there are newly updated primary data files that need reprocessing. This doesn't seem unreasonable to me, though I'm open to second opinions on how best to do this, too.

    the lowliest monk

      That seems reasonable then.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://462135]
help
Chatterbox?
[hippo]: Understood. I'll have to go through the code and see if it's doing anything fancy with ties, dual-vars or non-scalars. In the end, it's probably a bug though.
[Corion]: Aaah - you should be able to do this with overload, but I would hit somebody really hard if they constructed objects that are true but the empty string, and you not knowing about the domain knowledge where this makes sense
[Eily]: you could tie a variable into not having the same value each time, if you like to make people who try to debug your code facepalm
[Corion]: perl -wle 'package o; use overload q("") => sub {warn "str"; ""}, bool => sub{warn "bool"; 1}; package main; my $o={}; bless $o => o; print "Yay" if ($o && !length($o))'
[Corion]: But people writing such code should document the objects they construct and why it makes sense for an object to be invisible as string while being true in a boolean context
[hippo]: That's equal parts clever and horrendous.
[Eily]: the overload version wouldn't return true with "$x" && !length $x though, I guess
[hippo]: The more I look at this code, the more $x is a plain old scalar and the more this condition will never be true. I'm calling it a bug at this point.

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (14)
As of 2017-07-27 13:38 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    I came, I saw, I ...
























    Results (413 votes). Check out past polls.