Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: Slow Regex - How to Optimize

by dave_the_m (Monsignor)
on Aug 30, 2005 at 21:50 UTC ( [id://487961]=note: print w/replies, xml ) Need Help??


in reply to Slow Regex - How to Optimize

You code causes the regex to be recompiled each time round the inner loop. A slight rearrangement should improve things:
foreach my $sub ( keys %SUBS ) { my $re = qr/[^a-zA-Z]$sub[^a-zA-Z]*\(/; foreach my $line ( @sub_code ) { if ( $line =~ $re ) { push( @subs, $key ) } } }

Dave.

Replies are listed 'Best First'.
Re^2: Slow Regex - How to Optimize
by ikegami (Patriarch) on Aug 30, 2005 at 22:05 UTC

    That's not true. m/.../ only recompiles if the contents of any interpolated variable has changed. Demo:

    use re 'debug'; foreach (qw( abc abc def )) { print("==============================\n"); print("$_\n"); print("\n"); /$_/; }

    Update: Oops, I didn't notice you reversed the loops in addition to moving the regexp.

Re^2: Slow Regex - How to Optimize
by Anonymous Monk on Mar 11, 2016 at 14:14 UTC
    great post.. thanks a lot :) it really solved an issue here. reduced the runtime of a usecase from 30 minutes to ~10 seconds. hats off! :)

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://487961]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others cooling their heels in the Monastery: (6)
As of 2024-03-19 02:35 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found