Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

Re: Slow Regex - How to Optimize

by dave_the_m (Parson)
on Aug 30, 2005 at 21:50 UTC ( #487961=note: print w/ replies, xml ) Need Help??


in reply to Slow Regex - How to Optimize

You code causes the regex to be recompiled each time round the inner loop. A slight rearrangement should improve things:

foreach my $sub ( keys %SUBS ) { my $re = qr/[^a-zA-Z]$sub[^a-zA-Z]*\(/; foreach my $line ( @sub_code ) { if ( $line =~ $re ) { push( @subs, $key ) } } }

Dave.


Comment on Re: Slow Regex - How to Optimize
Download Code
Re^2: Slow Regex - How to Optimize
by ikegami (Pope) on Aug 30, 2005 at 22:05 UTC

    That's not true. m/.../ only recompiles if the contents of any interpolated variable has changed. Demo:

    use re 'debug'; foreach (qw( abc abc def )) { print("==============================\n"); print("$_\n"); print("\n"); /$_/; }

    Update: Oops, I didn't notice you reversed the loops in addition to moving the regexp.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://487961]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (4)
As of 2014-08-21 23:19 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The best computer themed movie is:











    Results (144 votes), past polls