Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re: Re (tilly) 1: What Happened...(perils of porting from c)

by Madams (Monk)
on Jan 05, 2001 at 19:10 UTC ( #50070=note: print w/replies, xml ) Need Help??

in reply to Re (tilly) 1: What Happened...(perils of porting from c)
in thread What Happened...(perils of porting from c)

Hey thanx for the critique ...

Added "use strict" , switched to a perl aware editor (boy that caught alot just switching editors)(changed @curlevel to $curlevel..the GOOD editor caught that)

split up the stmt that had the "||" in it (that somehow fixed that), fixed the munged comments, and that oneline for loop. Now no syntax errors (yeah!)

Mostly i am looking for someone to tell me if i got the pointer arithmetic related crap ported right .. when i use the module i'm getting some nonsense output (examples are uploaded to here).

One thing why get rid of the "return 1;" at the end? every example of writing a module says it should return "1" to signal proper loading.
  • Comment on Re: Re (tilly) 1: What Happened...(perils of porting from c)

Replies are listed 'Best First'.
Re (tilly) 3: What Happened...(perils of porting from c)
by tilly (Archbishop) on Jan 05, 2001 at 22:35 UTC
    The reason for removing the return statement is that you are not supposed to use that outside of functions (eval, do).

    Just end with:

    and it will work.

    As for the pointer logic, sorry. No energy to go through it. It looked like a mess FWIW. I would just use recursion for this problem. (OK, so you take a performance hit.)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://50070]
choroba was busy with the Pull Request Challenge
marto must set time aside for cpan things, life is just too crazy at the moment

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (6)
As of 2017-01-23 09:59 GMT
Find Nodes?
    Voting Booth?
    Do you watch meteor showers?

    Results (192 votes). Check out past polls.