Re^3: Weather RSS image

[pg]

in reply to Re^2: Weather RSS image
in thread Weather RSS image

Unfortunately your Perl code does not work. I called binmode() in my code for a reason. Your code would be fine with html files, but with images, it does not work.

If you test your code, you will see that some images are broken (or cannot be recognized as the right format).

[ikegami]

Huh? getstore calls binmode:

    elsif (!ref($arg)) {
        # filename
        open(OUT, ">$arg") or
            return HTTP::Response->new(&HTTP::Status::RC_INTERNAL_SERV
+ER_ERROR,
                "Cannot write to '$arg': $!");
        binmode(OUT);

source

Call stack:

• LWP::Protocol::collect
• LWP::Protocol::http::request
• LWP::UserAgent::send_request
• LWP::UserAgent::simple_request
• LWP::UserAgent::request
• LWP::Simple::getstore

It's not a recent addition either. The version of libwww-perl packaged with ActiveState Perl v5.6.1 does the same thing.

I've successfully downloaded all the images on a Windows system (where binmode would matter) using getstore and ActiveState Perl v5.6.1.

[davidrw]

It does work (well, i had to do s/Sumple/Simple/ first ;) ) -- and running file weather* afterward shows "GIF image data, version 89a, 52 x 52" for all of them ...
which images did you see as broken? Did you try re-downloading them?