Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

Re: Ping log terminates unexpectedly

by AcidHawk (Vicar)
on Mar 23, 2006 at 14:07 UTC ( #538748=note: print w/ replies, xml ) Need Help??


in reply to Ping log terminates unexpectedly

I am not sure why the code terminates, however I do have a comment about your code.

You open a handle to the log file each time you process a host from your @hostnames array. Perhaps you could look at opening the file handle once before processing the entire array. Also you may want to only sleep after the foreach...

Something like

use strict; use Time::Local; use Net::Ping; my ($time); my @hostnames = ("10.0.0.1", "10.0.0.2"); my $p = Net::Ping->new("icmp"); my $hostname; print "\nWriting data to ping.log\n"; print "Press CTRL-C to exit\n"; while(1) { open (LogFile, ">>ping.log") || die "Sorry, cannot open logfile\n" +; foreach my $hostname (@hostnames) { $time = localtime; print (LogFile "$time - "); print (LogFile "$hostname is "); print (LogFile "NOT ") unless $p->ping($hostname, 2); print (LogFile "reachable.\n"); } close Logfile; sleep(5); }

These changes will not affect you unless you @hostnames array grows to more than 1 host though.

-----
Of all the things I've lost in my life, its my mind I miss the most.


Comment on Re: Ping log terminates unexpectedly
Download Code
Re^2: Ping log terminates unexpectedly
by Scrat (Monk) on Mar 23, 2006 at 14:30 UTC
    I also thought it was a server reboot, but when I connect to the terminal session (I forgot to add it is a Windows2000 Server), everything is exactly as it was, except for my script window. No errors. Apologies - I should have said "my script terminates", not the log file.

    I thought there might be something wrong with my code.. or something I could add..

    Thanks for the comments AcidHawk.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://538748]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (16)
As of 2014-07-29 18:02 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (225 votes), past polls