Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things

Re: Consideration for others code

by Albannach (Prior)
on May 23, 2006 at 13:50 UTC ( #551158=note: print w/replies, xml ) Need Help??

in reply to Consideration for others code

Do I point out the errors?
Certainly... but have you really found some?

I bet that "this doesn't run under strict" won't be considered to be an error by anyone who doesn't use strict in the first place. If you have uncovered real errors somewhere (i.e. the code doesn't do what it is supposed to, or it is vulnerable to an attack, or will fail on bad data), then certainly point them out in a spirit of cooperation and teamwork.

If not, perhaps you would consider building some tests for the existing code instead? This will first make you better aware of what their code is suposed to do, rather than having you working backward and trying to figure out what existing code actually does. Once you understand the specifications, and have tests to exercise the code, then you can say with some authority whether there are true errors. If not, I'd say leave that code alone and move to the next piece (there is always more). It may well be that an ugly little piece of cruft is perfectly functional and even robust and need never be touched again.

I'd like to be able to assign to an luser

Replies are listed 'Best First'.
Re^2: Consideration for others code
by tcf03 (Deacon) on May 23, 2006 at 14:24 UTC
    As I said - the code isn't really full of errors, mostly style differences. I am now the maintainer of the code, and for purpose of maintaining it - Id prefer it to be readable - to me, I am more concerned about stepping on toes and how some people here might deal with that. I have great respect for the people who wrote the code.

    Thanks for your suggestion of writing tests - my background is not in softare development, and its been suggested enough times to me by people who know and seems like a logicaland reasonable thing to do...


    "That which we persist in doing becomes easier, not that the task itself has become easier, but that our ability to perform it has improved."
      --Ralph Waldo Emerson

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://551158]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (4)
As of 2017-05-25 10:00 GMT
Find Nodes?
    Voting Booth?