Re: Build Table with 'n' rows and 'm' columns

[Samy_rio]

in reply to Build Table with 'n' rows and 'm' columns

Hi, Try like this,

use strict;
use warnings;
use DBI;
use HTML::TableTiler;    

my @matrix;

my $dbh = DBI->connect( "DBI:mysql:project") or die "Can't connect to 
+Oracle database: $DBI::errstr\n";
my $sth = $dbh->prepare("select * FROM modules");
$sth->execute || $sth->errstr();

while (my @row = $sth->fetchrow_array) {
 push (@matrix, [@row]);
}

$dbh->disconnect;

my $tt = HTML::TableTiler->new();
    
print $tt->tile_table(\@matrix);

Thanks ikegami++

[ikegami]

There room for a some small improvements.
• You don't check the result of $dbh->prepare.
• You don't check the result of $dbh->fetchrow_array.
• Your loop can be replaced with $sth->fetchall_arrayref.
• You can also condense the code further using $dbh->selectall_arrayref.

use strict;
use warnings;

use DBI ();
use HTML::TableTiler ();

my $dbh = DBI->connect("DBI:mysql:project")
   or die "Can't connect to Oracle database: $DBI::errstr\n";

my $matrix = $dbh->selectall_arrayref("SELECT * FROM modules");
die "Unable to fetch query results: $DBI::errstr\n" if $dbh->err;

my $tt = HTML::TableTiler->new();
print $tt->tile_table($matrix);

Update: I was obviously tired! Fixed the problems identified in replies.

[mreece]

there is still room for some small improvement!

Global symbol "$sth" requires explicit package name

;-)

[cLive ;-)]

And more. Personally, I prefer using SELECT over SELET ;-)

[andyford]

Ha Ha I like they way you mess with your users: failure to connect to a mysql database sends them looking for a failed Oracle instance.
Evil genius!

my $dbh = DBI->connect( "DBI:mysql:project") or die "Can't connect to 
+Oracle database: $DBI::errstr\n";

Update: Added code for quick reference.