Re: PerlMonks Editor

[GrandFather]

in reply to PerlMonks Editor

Version 1.0 Beta 1 of PMEdit is now available at http://cpan.perl.org/authors/id/G/GR/GRANDPA/PMEdit/PMEdit-001.000201-1.pl which may be accessed through http://cpan.perl.org/scripts/ or http://cpan.perl.org/scripts/Web/index.html (these had not refreshed last time I looked, but should soon).

A swag of rendering bugs have been fixed and various editing related additions have been made with much valuable assistance from planetscape.

[parv]

Running it w/ Tk 804.027 (x11-toolkits/p5-Tk port) & perl 5.8.8 on FreeBSD 6.x, spews (nothing else happens) ...

Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'P' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'U' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'I' used
Unhandled flag 'B' used
Unhandled flag 'P' used
Unhandled flag 'B' used
Unhandled flag 'R' used
Unhandled flag 'F' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'F' used
Unhandled flag 'B' used
Unhandled flag 'F' used
Unhandled flag 'L' usedline (32):
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'L' used
Unhandled flag 'R' used
Unhandled flag 'B' used
Unhandled flag 'L' used
Use of uninitialized value in string at PMEdit-001.000201-1.pl line 11
+46, <DATA> line 82.
bad event type or keysym "_" at PMEdit-001.000201-1.pl line 268, <DATA
+> line 82.

A few minutes later: Ok, the "uninitialized value" goes away if I delete the blank line at the end of __DATA__.

[GrandFather]

The line with whitespace on it (an empty line doesn't do it for me) is fairly trivial - but silly not to have found. Thanks for finding it for me!

The other issue I should have fixed before uploading, but I sort of forgot about it. On investigation it could be more important than I'd thought and has now been fixed in my current version. It probably doesn't affect current functionality, but my test suite runs against a module version of the code so I've not run the combined version against the test suite to check.

I'll upload an updated version to CPAN soon.

Thanks for the help!

Update: an updated version has been uploaded as http://cpan.perl.org/authors/id/G/GR/GRANDPA/PMEdit/PMEdit-001.000202-1.pl and should appear soonish at a mirror near you. ;)

[parv]

Hey, happy to help. But my helping you is not done yet. ;}

Program stops after printing "bad event type" message .. .

bad event type or keysym "_" at PMEdit-001.000202-1.pl line 269, <DATA
+> line 81.

... but that goes away (and a Tk window emerges) if I change _ to one of [a-zA-Z0-9] but not [-+].

Other minor problems ... (1) chomp fails to clear ^M in __DATA__ ...

1057 sub LoadConfig {
1058     my $ok = 1;
1059
1060     while (<DATA>) {
1061         # Load the default configuration stuff
1062         chomp;
1063         next if ! length;
     ...
1067         my ($tag, $htmlTag, $name, $flagsField, @options) = split
+ /\s*,\s*/;
1068
1069         if (! defined $flagsField) {
1070             print "Missing entries in tag line ($.): $_";
     ...

... which causes above print() to act; line numbers reported are 32 & 58.

(2) Later in LoadConfig(), chomp() is rendered useless by use of s/\s+$//; ...

1136     while (<DATA>) {
1137         # Load key binding information
1138         next if /^#/;
1139
1140         chomp;
1141         s/^\s+//;
1142         s/\s+$//;

In both cases, I suggest just use s/\s+$// & chop the chomp().

(3) There seems to spurious tab characters on lines 228, 769, 771-772, 774-775.

diff -u output follows ...

Read more... (2 kB)