Re: Passing user input to a shell command

[jdporter]

in reply to Passing user input to a shell command

You should not be using qw in the system call. Take it out.

Try this, to see why:

print "$_\n" for qw "perl /Users/james/perlstuff/macc/macc1 $file";

You might have other problems with that program as well.
For starters, you should probably chomp($file) immediately after reading it in.
Also, you're opening the file for reading, then immediately passing the filename to an external program. I really don't think you want to do both. You certainly don't need to open a file before passing it to an external program; that program will do what it wants with the name, and wouldn't see your open filehandle anyway.
Thirdly, you're pulling in the Shell module, but not using it. You could use it, by doing this:

use Shell qw( perl );

. . .

perl "/Users/james/perlstuff/macc/macc1", $file;

[james734]

I know that the file $file does not exist, I open it to insure that user is typing the file exists. The question should have been how do I tell the shell line that $file = <STDIN> is the value that is entered by the user and to put it into the shell line ie User enters test.txt So $file is now = test.txt the shell command shout be perl /Users/james/perlstuff/macc/macc1 test.txt. James

[james734]

Ignore me I got it working

[eric256]

In a forum it is polite to explain what you did to fix it. That way when someone else has a similar problem and finds your thread, they can then use your solution! ;)

[jdporter]

I open it to insure that user is typing the file exists

Opening it is not the best way to do that. There are the file test operators, such as -f:

-f $file or die "You specified a non-existent file.\n";

Even if you do open it for this purpose, you should definitely close it right away, before letting another process have it.

[adrianh]

You should not be using qw in the system call

Or, you should be using qw() but you need to fully specify the path to perl. That way you don't have to worry about $file having spaces in it.

[jdporter]

Did you try this?

print "$_\n" for qw "perl /Users/james/perlstuff/macc/macc1 $file";