Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot

Re: Seeker of Perl Code Review

by diskcrash (Hermit)
on Mar 22, 2001 at 12:39 UTC ( #66276=note: print w/replies, xml ) Need Help??

in reply to Seeker of Perl Code Review


What a ton of work!

I browsed the sample files and looked at the doc pages. Took a quick look through the code.


The black on white was most readable to me, except a darker gray would be good for comments. (I'm a tad colorblind.)

The doc page was very well formatted and thought out.

The code was well commented and formatted.

Is there any thought to a switch that would highlight bracket/paren pairs? Or flag unpaired "pairs".

Overall, what a great tool!


Replies are listed 'Best First'.
(bbfu) Re: Re: Seeker of Perl Code Review
by bbfu (Curate) on Mar 23, 2001 at 02:07 UTC

    Thanks! To respond to your comments:

    1. The black on white was most readable ... darker gray ... for comments.

      I tried to make a few general Styles that would cover most of the range, but they were really only intended as examples. Did you try the Customize It (Style) button? You can easily alter one or two things from one of my pre-defined Styles, or go crazy and define your own. :-) And if you write your own implementation using the module, of course, you can insert any formatting you like.

    2. The doc page [and code] [were] well formatted [and commented]


    3. Is there ... a switch that would highlight bracket/paren pairs? Or flag unpaired "pairs"[?]

      Currently, parentheses, brackets (square and curly), and semicolons are all considered 'Symbol's. You can only format them all together. :-( It would be trivial to modify the formatter to distinguish between paren/brackets and "other symbols" so perhaps I'll add it soon. The module doesn't actually parse the code, however, since we all know only perl can parse Perl. ;-) Rather, it works by "tokenizing" the code: breaking it into small pieces that can be recognized as "syntactically significant" and formatted properly. This is not a 100% solution but it seems to work well (enough). One big problem with this approach (or perhaps just my implementation of it) is that it is rather stream-oriented. In otherwords, the formatter can't back-track to the unmatched opening bracket when it realizes that it is unmatched. I'm hoping to eventually incorporate a back-tracking mechanism, as it will be usefull for many things that can't currently be done, but I'm having trouble figuring out how to do it. Hopefully someone here at the Monastery will chime in and help out! :-)

    Well, once again I would like to thank you and everyone else who has responded. And I hope that people will find this module usefull!

    Seasons don't fear The Reaper.
    Nor do the wind, the sun, and the rain.
    We can be like they are.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://66276]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (4)
As of 2018-02-18 07:50 GMT
Find Nodes?
    Voting Booth?
    When it is dark outside I am happiest to see ...

    Results (251 votes). Check out past polls.