Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re: Students Rank calculation for the below perl script

by hipowls (Curate)
on Apr 15, 2008 at 08:00 UTC ( #680449=note: print w/ replies, xml ) Need Help??


in reply to Students Rank calculation for the below perl script

There are a few things I would do differently

  • I'd put the most of the variables into the loop, restricting the scope to just the places they are used will spare you some grief later.
  • You need to test that your regular expression matched, if it doesn't you end up processing the previous record again.
  • If you have a student with the surname O'Hara you will fail to process her records.
  • $status has the value of the last mark checked, I think you mean to check if any failed
  • The use of . to join the strings is ugly, use variable interpolation instead.

Anyway this is my version, it still fails to report marks for Ms. O'Hara but at least you will get a warning, and I have to leave something for you;-) The other change is to not explicitly code the number of tests, this will work if the input file has results of four tests.

#!/net/perl/5.10.0/bin/perl use strict; use warnings; use List::Util qw(sum); my $input_file = 'marks.txt'; open my $DATA, '<', $input_file or die "Can't open $input_file: $!\n"; while ( my $line = <$DATA> ) { next if $line =~ /^NAME/; chomp $line; if ( $line =~ /^\w+,\w+(?:,\d+)+$/ ) { my ( $first_name, $last_name, @marks ) = split ',', $line; my $totalmarks = sum @marks; my $average = sprintf "%.2f", $totalmarks / @marks; my $fail = 0; foreach my $mark (@marks) { $fail ||= checkfail($mark); } if ( !$fail ) { print "$first_name $last_name\t@marks \t$totalmarks\t$aver +age\n"; } else { print "$first_name $last_name\t@marks \t\n"; } } else { warn "Invalid input: $line\n"; } } close $DATA or die "Can't close $input_file: $!\n"; #To check whether the student failed sub checkfail { my $marks = shift; return $marks < 35; } john michael 100 50 60 210 70.00 sam shane 50 60 70 180 60.00 tom christo 30 40 50

You may wish to give consideration to using Text::CSV_XS for parsing comma delimited text files.

Update: two small code modifications kindly suggested by moritz.


Comment on Re: Students Rank calculation for the below perl script
Select or Download Code
Re^2: Students Rank calculation for the below perl script
by moritz (Cardinal) on Apr 15, 2008 at 08:14 UTC
    Just two minor remarks:
    my $totalmarks = reduce { $a + $b } @marks;

    If you resort to List::Util (Which isn't a bad idea at all) you can just as well use sum @marks.

    my $fullname   = "";

    Since you don't use it, you don't have to declare it.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://680449]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (11)
As of 2014-10-22 08:57 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (114 votes), past polls