Re^2: Spreadsheet::ParseExcel Script Fails to Parse (access) Excel Spreadsheet

[finhagen]

I added the strict and warnings and heeded the ensuing warnings. I added my to my variables. I also eliminated any DBI and other distacting code from the script. The script compiles properly, but I still don't get any output from my print statements which implies the file is not getting parsed.

#!/usr/bin/perl

use strict;
use warnings;
use Spreadsheet::ParseExcel;

my $file = "\\lebensraum\\perl\\SAMReport.xls";

my $workbook = Spreadsheet::ParseExcel::Workbook->Parse($file)or die "
+Unable to open $file\n";

#locate columns in the spreadsheet from which we want to extract data
foreach my $sheet (@{$workbook->{worksheet}}) {
print "Sheet number $sheet\n";

    foreach my $col ($sheet->{MinCol} .. $sheet->{MaxCol}) {
        if ($sheet->{Cells}[0][$col]->{Val} eq "Site Number") {
            my $siteid = $col;
            print "$siteid\n";}
        else {print "Could not find column Site Number\n";}

        if ($sheet->{Cells}[0][$col]->{Val} eq "Site Name") {
            my $name = $col;
            print "$name\n";}
        else {print "Could not find column Site Name\n";}

        if ($sheet->{Cells}[0][$col]->{Val} eq "City") {
            my $city = $col;
            print "$city\n";}
        else {print "Could not find column City\n";}
    }

#iterate through spreadsheet rows and extract site.siteid,site.name & 
+site.city

foreach my $row ($sheet->{MinRow}+1 .. $sheet->{MaxRow}) {

    my $site_number = $sheet->{Cells}[$row][my $siteid]->{Val};
    my $site_name = $sheet->{Cells}[$row][my $name]->{Val};
    my $site_city = $sheet->{Cells}[$row][my $city]->{Val};

    print "$site_number\n";
    print "$site_name\n";
    print "$site_city\n";


    }
}
exit;

[bmann]

foreach my $sheet (@{$workbook->{worksheet}}) {

Case sensitivity - should be @{$workbook->{Worksheet}}, not worksheet

HTH

[finhagen]

Thanks so much for everyone's help. I am making progress. Changing the worksheet to Worksheet and then using just the file name for my xls file allowed me to parse the spreadsheet. However, the output of my parsing isn't correct and it looks like the breakdown is the capturing of the column data (e.g. $city =$col;) isn't carrying over to the row iteration. In my efforts to correct that I am encountering a compile error:

Global symbol "$siteid" requires explicit package name at ./excel.syr.
+extract3.pl line 48.
Global symbol "$name" requires explicit package name at ./excel.syr.ex
+tract3.pl line 49.
Global symbol "$address" requires explicit package name at ./excel.syr
+.extract3.pl line 50.
Global symbol "$city" requires explicit package name at ./excel.syr.ex
+tract3.pl line 51.
Global symbol "$state" requires explicit package name at ./excel.syr.e
+xtract3.pl line 52.
Global symbol "$zip" requires explicit package name at ./excel.syr.ext
+ract3.pl line 53.
Execution of ./excel.syr.extract3.pl aborted due to compilation errors
+.

I imagine that the "explicit package name" issue is something the PerlMonks understand well, but I have to confess I don't know what it means or what to do about it. Here is my latest script:

#!/usr/bin/perl

use strict;
use warnings;

use Spreadsheet::ParseExcel;


my $file = "SAMReport.xls";

my $workbook = Spreadsheet::ParseExcel::Workbook->Parse($file)or die "
+Unable to open $file\n";

#locate columns in the spreadsheet from which we want to extract data
foreach my $sheet (@{$workbook->{Worksheet}}) {
print "Sheet number $sheet\n";

    foreach my $col ($sheet->{MinCol} .. $sheet->{MaxCol}) {
        if ($sheet->{Cells}[0][$col]->{Val} eq "Site Number") {
            my $siteid = $col;
        }

        if ($sheet->{Cells}[0][$col]->{Val} eq "Site Name") {
            my $name = $col;
        }

        if ($sheet->{Cells}[0][$col]->{Val} eq "Address") {
            my $address = $col;
        }

        if ($sheet->{Cells}[0][$col]->{Val} eq "City") {
            my $city = $col;
        }

        if ($sheet->{Cells}[0][$col]->{Val} eq "State") {
            my $state = $col;
        }

        if ($sheet->{Cells}[0][$col]->{Val} eq "Zip Code") {
            my $zip = $col;
        }
    }

#iterate through spreadsheet rows and extract site.siteid, site.name, 
+site.address, site.city, site.state, site.zip
foreach my $row ($sheet->{MinRow}+1 .. $sheet->{MaxRow}) {

    my $site_number = $sheet->{Cells}[$row][$siteid];
    my $site_name = $sheet->{Cells}[$row][$name];
    my $site_address = $sheet->{Cells}[$row][$address];
    my $site_city = $sheet->{Cells}[$row][$city];
    my $site_state = $sheet->{Cells}[$row][$state];
    my $site_zip = $sheet->{Cells}[$row][$zip];

#print captured output
    print "$site_number\n";
    print "$site_name\n";
    print "$site_address\n";
    print "$site_city\n";
    print "$site_state\n";
    print "$site_zip\n";

    }
}
exit;

Thanks again for everyone's kind assistance! Hagen

[Anonymous Monk]

#!/usr/bin/perl --

use strict;
use warnings;
use diagnostics;

my $foo = 1;
{# a new scope
   my $bar = 2;
}# end of new scope

my $baz = $bar; # $bar doesn't exist in this scope
__END__

Global symbol "$bar" requires explicit package name at test.pl line 12
+.
Execution of test.pl aborted due to compilation errors (#1)
    (F) You've said "use strict vars", which indicates that all variab
+les
    must either be lexically scoped (using "my"), declared beforehand 
+using
    "our", or explicitly qualified to say which package the global var
+iable
    is in (using "::").

Uncaught exception from user code:
        Global symbol "$bar" requires explicit package name at test.pl
+ line 12.
Execution of test.pl aborted due to compilation errors.
 at test.pl line 13

To "fix" it, you do something like

my $foo = 1;
my $bar;
{# a new scope
   $bar = 2;
}# end of new scope

my $baz = $bar;