Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: How many bugs can *you* find

by MeowChow (Vicar)
on May 01, 2001 at 01:39 UTC ( #76769=note: print w/ replies, xml ) Need Help??


in reply to How many bugs can *you* find

Ooh, fun! Pick apart code without worrying about hurting someone's ego ;)

my $fto = $htmDir . 'tile.htm'; # yuck: hard-coded file name in a subroutine open(HOME,$fto); # blargh, no error checks, are we using -T, and if not, is $htmDir # based on user-supplied data? foreach $section (@sections) { # if this compiles, I guess we're not using strict, eh? ($section is # not declared my) # # ... I don't even want to comment on the nastiness of the innards of +the # foreach loop, but I will anyway. Iterating over the hard-coded value +s in @section, only # to test if you are iterating over one of those values is silly code. # # What should have been done is to save the relevent query params to a + hash # and then process each param as needed, without employing the silly c +onditional # logic and synthetic $contentTemp variable # # I also can't imagine any circumstance in which having a (.*) to gobb +le up # the content in $content is a good thing. # open(HOME,">$fto"); # again, no error checks, and no locking.
   MeowChow                                   
               s aamecha.s a..a\u$&owag.print


Comment on Re: How many bugs can *you* find
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://76769]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (12)
As of 2014-07-14 12:06 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    When choosing user names for websites, I prefer to use:








    Results (258 votes), past polls