Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re: Re: (Ovid) Re(2): How many bugs can *you* find

by merlyn (Sage)
on May 01, 2001 at 18:30 UTC ( #76969=note: print w/ replies, xml ) Need Help??


in reply to Re: (Ovid) Re(2): How many bugs can *you* find
in thread How many bugs can *you* find

Actually, $section can't have regex characters as the code is written, since it simply iterates over the hard-coded items in @sections
As written, but not as maintained. {grin}

For this to pass code review for me, there'd either need to be a fix to that line to make it work even when $section has regex chars, or a note put up above saying "don't ever include regex chars in this string... see below".

The reason I flag that is that it creates an intertwining dependency that will be hell for the maintenance programmer down the road. Trust me: I've been that maintenance programmer enough times to know how much I hate those things. That's why my code reviews are so thorough. {grin}

-- Randal L. Schwartz, Perl hacker


Comment on Re: Re: (Ovid) Re(2): How many bugs can *you* find

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://76969]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (17)
As of 2015-07-29 16:43 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (265 votes), past polls