Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: Why Create Coding Standards and Perform Code Reviews?

by gwadej (Chaplain)
on Jul 02, 2009 at 13:41 UTC ( #776746=note: print w/replies, xml ) Need Help??


in reply to Why Create Coding Standards and Perform Code Reviews?

Well done.

The only points I can think of to add are relatively trivial.

Like the code base and the experience of the developers, coding standards should/will evolve over time. As new best practices emerge, the coding standard should take these into account. (I once worked at a shop with a well-defined coding standard that advocated best practices from 15 years earlier. Unfortunately, the world had changed in that time.)

Depending on the review type, there is a benefit of code reviews that many people miss: increasing the company's Bus Number. I worked at one place that used tool-assisted code reviews. We had multiple people on every review.

This helped spread knowledge about individual modules and their usage. As a side effect, several modules that were only known by one person became partially understood by many. Although some developers won't like this (the old job security argument), most people seem to understand the benefits.

G. Wade
  • Comment on Re: Why Create Coding Standards and Perform Code Reviews?

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://776746]
help
Chatterbox?
[erix]: "code of someone that died" -- kinda nice if your code stops working too
[erix]: hard to implement, hmm
[Corion]: erix: Well, they also seem to have changed the server, or some software, or whatever, and seem to be in the process of changing the DB schema from having the "username" as primary key to something else.
[Corion]: Far too many things being done at once, or maybe only now has it become apparent that nobody knows that piece of software anymore
[marto]: good morning all
[Corion]: I consider having an abstract key as userid in your system good, because the "real" company-wide (or even larger) user id will likely not fit your criteria well
[Corion]: A good morning marto!

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (8)
As of 2017-01-23 09:35 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Do you watch meteor showers?




    Results (192 votes). Check out past polls.