Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: ok I know it's crap but I'm proud of it...

by Mungbeans (Pilgrim)
on May 10, 2001 at 15:04 UTC ( #79357=note: print w/ replies, xml ) Need Help??

in reply to Peer review of Cisco switch administration utility (was: ok I know it's crap but I'm proud of it...)

Looks cool, some brief comments:

You may want to use Getopt::Long and pod2usage to get your arguments, and print errors if insufficient args (perldoc getopt::long). I like to assign args to my variables early rather than passing ARGV around - it makes it easier to work out what parameters a subroutine is using.

Consider validating the IP addresses after you get parameters, drop a warning message then and only feedip the valid ones. This reduces the nesting.

Comment on Re: ok I know it's crap but I'm proud of it...

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://79357]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (2)
As of 2015-10-09 03:16 GMT
Find Nodes?
    Voting Booth?

    Does Humor Belong in Programming?

    Results (232 votes), past polls