Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Re: ok I know it's crap but I'm proud of it...

by Mungbeans (Pilgrim)
on May 10, 2001 at 15:04 UTC ( #79357=note: print w/replies, xml ) Need Help??


in reply to Peer review of Cisco switch administration utility (was: ok I know it's crap but I'm proud of it...)

Looks cool, some brief comments:

You may want to use Getopt::Long and pod2usage to get your arguments, and print errors if insufficient args (perldoc getopt::long). I like to assign args to my variables early rather than passing ARGV around - it makes it easier to work out what parameters a subroutine is using.

Consider validating the IP addresses after you get parameters, drop a warning message then and only feedip the valid ones. This reduces the nesting.

  • Comment on Re: ok I know it's crap but I'm proud of it...

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://79357]
help
Chatterbox?
[Discipulus]: just in Eataly: brain surgery while playing clarinet..
[erix]: installing perfect pitch?
[karlgoethebier]: ...good Hot tuna. Note the stacks & racks in the background
[karlgoethebier]: ..the last hippies. They still perform. At least the survivors...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (13)
As of 2017-11-17 20:16 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    In order to be able to say "I know Perl", you must have:













    Results (272 votes). Check out past polls.

    Notices?