in reply to
A matter of style: how to perform a simple action based on a simple condition?
To me, the only consideration is that: the code must be obvious and consistent. Every “shop” will develop “accepted practices,” and the most important thing that you must do is to follow them. Source code size is not a consideration. The computer is blisteringly fast. Disk space is unlimited. If you can’t type, hire a typist.
Anyone who looks at your code must be able to understand at a glance what it is doing, and their “glance” must be correct. Remember that people see what they expect to see, as demonstrated by this old chestnut:
“PARIS IN THE SPRING
,” right? Look again.
So, “the correct style” is to first find out how your shop is writing such things now, and then to proceed to do it in exactly the same way. Otherwise, find what is the most abundantly clear way to write it... which is usually not the most brief.
Finally, always consider changes. The code that you write will one day be changed, probably in a hurry, probably not by you. Does “a slight change” to your code “break it?” Especially... does it “break it” in such a way that it no longer works as intended, but also does not produce a syntax-error? The consequences of any such change can be disastrous.