prepare insert statement outside while loop for speed

[Anonymous Monk]

Esteemed monks

I am new to perl and trying to get to grips with the dbi. Is this the correct way to prepare an insert statement outside a while loop for speed?

my $insert_snp_sql = "insert into $tableName (Chr, Pos_start, Pos_end,
+  id, reference, genotype) values (?,?,?,?,?,?)";
my $sth = $db->prepare ($insert_snp_sql);  
while(<INFH>){
#process input line and then insert to database       

        if ($sth->execute($data[0],$data[1],$data[2], $data[3], $data[
+4],$data[5])) {
              #insert ok
       }
}

thanks a lot

[JavaFan]

Yes.

[Anonymous Monk]

thanks!

[McDarren]

$sth->execute($data[0],$data[1],$data[2], $data[3], $data[4],$data[5])

The above could be written a bit more succinctly as:

$sth->execute(@data[0 .. 5])

See Slices

Or, if you know that @data will always contain just six elements, then just simply:

$sth->execute(@data)

Hope this helps,
Darren