Beefy Boxes and Bandwidth Generously Provided by pair Networks Bob
Welcome to the Monastery
 
PerlMonks  

Re^11: incrementing already existing file

by broomduster (Priest)
on Mar 03, 2011 at 13:50 UTC ( #891222=note: print w/ replies, xml ) Need Help??


in reply to Re^10: incrementing already existing file
in thread incrementing already existing file

In this section of your code:

while ( <MYFILE> ) { chomp; my( $label, $index, $value ) = ( split /\s+/ )[3, 5, -1]; $a_vals[ $index ] = $value; $b_vals[ $index ] = $value; }
You need to check the value of $index to get the values for type 'A' into @a_vals, similarly for the 'B' values. The way you have it, you only get 'B' values because they are the last ones in MYFILE, and you are putting the same things into both @a_vals and @b_vals. Since the 'B' values come in last, they overwrite the corresponding 'A' values in @a_vals. You can use the same kind of if/elsif/else logic as in your other loop to fix this(but see comments below on ways to improve that).

Now for this part of the loop over NEWF:

if ($label eq "A"){ $fields[-2] = $a_vals[ $index ] } if ($label eq "B"){ $fields[-2] = $b_vals[ $index ]

You should use if / elsif / else here:

if ($label eq "A") { $fields[-2] = $a_vals[ $index ] } elsif ($label eq "B") { $fields[-2] = $b_vals[ $index ] } else { print "OOPS! bad label\n"; # complain if something is fishy }

You're getting there.


Comment on Re^11: incrementing already existing file
Select or Download Code
Re^12: incrementing already existing file
by wanttoprogram (Novice) on Mar 03, 2011 at 16:50 UTC
    Perfect. It worked. Thank you for your clean answers and time.
      My pleasure. I'll offer one other piece of advice. roboticus already said pretty much the same thing here, but it bears repeating. Get into the habit of keeping nested blocks of code properly indented; each new block should be indented more than the block that contains it. When you see that you have levels of indentation (i.e., many levels of nesting), it's usually a clue that you need to think again about what you are doing. As you get more experience, this will become automatic, but you can always use a program called perltidy to help you keep things neat.

      Keep at it. You will get the hang of it. I just takes practice.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://891222]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (5)
As of 2014-04-20 14:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    April first is:







    Results (485 votes), past polls