Re^2: (solved) Clean smoke-test install for Inline based modules using Inline::MakeMaker

[syphilis]

As an added benefit, by causing EU::MM to upgrade (if necessary), the warning about not recognizing the CONFIGURE_REQUIRES directive goes away.

I gather that's the *only* reason for adding the EU::MM requirement - I don't see that it could serve any other purpose.
No problem with any of that but I'll specify '6.52' instead of '6.62'. According to the EU::MM Changes file 6.52 would be the earliest stable version to be aware of the CONFIGURE_REQUIRES option. It so happens that I have 6.52 on one of my builds of perl, and it doesn't complain about the option. (Version 6.48 *does* complain.)

I'll wait for a week in case there are any more developments, then I'll upload your suggested amendment to github so that it's sitting there in readiness for the next Inline release.
It's unlikely I'll forget about it, but please ping me if I do :-)

Cheers,
Rob

[davido]

Yes, that's the only reason. Perhaps it's not a very good reason, as a warning wouldn't cause an install failure anyway, right? Might not be worth forcing people to upgrade EU::MM just to squelch a warning.

However, it would be worth mentioning in the POD for Inline that the CONFIGURE_REQUIRES directive requires that the person creating the distribution have EU::MM version 6.56 (or whatever it was) installed on his system.

Opinions?

[syphilis]

Opinions?

I think we could recommend that CONFIGURE_REQUIRES include EU::MM in addition to Inline::MakeMaker - but then explain why we've included EU::MM, and let people make up their own mind as to whether they wish to do the same.

Should CONFIGURE_REQUIRES specify Inline::MakeMaker or should it specify Inline ?
I guess it doesn't matter much (you won't get one without the other) so long as Inline gets found and installed. I'll leave that part as is unless someone wants to convince me that it should be changed to specify 'Inline'.

Cheers,
Rob

[davido]

It definitely should be Inline::MakeMaker. According to the docs for ExtUtils::MakeMaker, CONFIGURE_REQUIRES, BUILD_REQUIRES, etc. should point to a module, and not a distribution.

By the way, I noticed that Inline and Inline::C are v0.48, but Inline::MakeMaker, included with that dist. is v0.45.

[GrandFather]

I'd be inclined to put those sort of directions in a dev-readme.txt file (perhaps in the /t folder) or maybe as a "For maintainers" section in the README file rather than cluttering the POD with stuff that isn't pertinent to users.

[davido]

I see where you're going with that thought, and you may be right. But Inline currently does have a section entitled "Writing Modules with Inline". And it discusses the make dist topic. It's just incomplete in light of what we've been discovering the past few days. Perhaps that whole section could be split out into its own POD file similar to Inline::C-Cookbook.