Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic

Re: Perl Cipher & questions on semantics/layout optimisation.

by repellent (Priest)
on Feb 25, 2012 at 07:43 UTC ( #956075=note: print w/replies, xml ) Need Help??

in reply to Perl Cipher & questions on semantics/layout optimisation.

Hi, and welcome to Perlmonks! Here's my take on your code:

Find for the following line. It's in the first inner for-loop.
$offsetpattern .= chr((ord(@karray[i])+ord(@karray[i2])+ ord($offset2[ +$i % length($key)]))%256);

Notice that you have the bare variables i and i2. They ought to be $i and $i2 instead (you forgot the $). Also, the array @offset2 is not defined yet at this code point. Plus, indexing into an array should be $karray[$i] instead of @karray[$i].

Then, I notice that you call ord and chr a lot. You are joining characters only to split them later again, and that is (wasted) redundant work. In the case of the key array, you can start off by mapping the ordinals:
my @karray = map ord, (split //, $key);

That saves you the work of calling ord like ord($karray[$i2]) a whole bunch of times. This can also apply to your offset arrays. Keeping all your array elements as ordinals will make your code more concise; no need for intermediate strings.

By the way:
my @karray = map ord, (split //, $key); my $len = length($key); # prints true for both print "true" if $len == @karray; print "true" if $len-1 == $#karray;

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://956075]
NodeReaper edits tomorrow's obituaries

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (11)
As of 2017-10-23 12:48 GMT
Find Nodes?
    Voting Booth?
    My fridge is mostly full of:

    Results (279 votes). Check out past polls.