Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re: Need a regex..

by scorpio17 (Abbot)
on May 21, 2012 at 13:35 UTC ( #971613=note: print w/replies, xml ) Need Help??

in reply to Need a regex..

Something like this, maybe?
use strict; while (my $data = <DATA>) { chomp $data; if ($data =~ /^\d?\d?\d\.\d\d?\d?$/) { print "GOOD\n"; } else { print "BAD\n"; } } __DATA__ 12.12 123.123 0.1 1234.0 1234

Replies are listed 'Best First'.
Re^2: Need a regex..
by littlemonk (Sexton) on May 21, 2012 at 13:55 UTC
    it should match non-decimal value also ...example 12,123, and it should not match more than 3 digits before and after decimal..i have one regex(/^\- \+{0,1}0-9{0,3}(\.){0,1}0-9{0,3}\%{0,1}$/) but its accepting 1234(more than 3 digits before decimal) ... plz help me

      Please wrap code it <code> tags to keep things legible. As you can see, your character classes got linkified.

      1234 is passing because it's being read as (123)(4). You should set the whole part following and including the decimal in a non-capturing group with a conditional: /^[-+]?[0-9]{0,3}(?:\.[0-9]{0,3})?%?$/ I've also removed a bunch of unnecessary escaping, and changed your {0,1} to the shorter ? synonym.

      A read through of perlretut may be helpful.

      #11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.

      Edit: Lost the race to Re: Need a regex.., which is also slightly better :)
      Try a more grouped approach:
      First the start of the line: ^
      then an optional + or - sign, with the + enclosed in [] to avoid interpretation: ([+]|-)?
      then 0-3 digits: [0-9]{0,3}
      then an optional group of a period followed by 1-3 digits, with the period escaped in another way to avoid interpretation: (\.[0-9]{1,3})?
      and finally the end of the line: $

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://971613]
and the fog begins to lift...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (4)
As of 2017-01-20 05:00 GMT
Find Nodes?
    Voting Booth?
    Do you watch meteor showers?

    Results (173 votes). Check out past polls.