Re: Assignments for Subroutines

[protist]

in reply to Assignments for Subroutines

The following is my version of part 1. You may find use diagnostics useful if you are new.

#!/usr/bin/perl
use strict;
use warnings;
use diagnostics;
        #more verbose feedback
        #useful for debugging

my@num = (1..10);

sub printeven{
        my @given=@_; #pull in list given later: printeven(@list)
        my @evens;
        for (@given){
                unless($_%2){ #unless odd
                        push(@evens,$_); #add number to @evens
                }
        }
        $,=", "; #change list delimiter for fancy printing
        print @evens;
        print "\n"; #newline
        $,=""; #change list delimiter back before it is a problem
}

printeven(@num); #call sub with list of numbers 1-10

[nemesdani]

$,=", "; #change list delimiter for fancy printing
print @evens;
print "\n"; #newline
$,=""; #change list delimiter back before it is a problem

That could be written as

{
local $,=", ";
print @evens;
print "\n"; #newline
}

No need to change it back, less possibility of an error. My 2 cents.

[protist]

That is better. You have my +1

[tobyink]

Indeed. Especially because this...

$,=""; #change list delimiter back before it is a problem

... changes the list delimited "back" to the empty string, when we never checked that it started off as the empty string to begin with!