Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re: Parsing Logs

by johngg (Abbot)
on Oct 05, 2012 at 18:14 UTC ( #997527=note: print w/ replies, xml ) Need Help??


in reply to Parsing Logs

You can also save some typing where you build your @array from the MSG file handle. Your

foreach $line (<MSG>) { chomp($line); push(@array, $line);

could be written

chomp( @array = <MSG> );

It is good practice to put

use strict; use warnings;

at the top of your scripts to enforce a little coding discipline and catch typos. It is also good practice to use lexical file handles, the three-argument form of open and to check that it succeeded (you do this), but also give the o/s error (see $! in perlvar) to give a better idea of why it failed.

open my $msgFH, q{<}, q{/some/file} or die qq{open: < /some/file: $!\n};

I hope these points are helpful.

Cheers,

JohnGG


Comment on Re: Parsing Logs
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://997527]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (7)
As of 2014-12-25 10:37 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (160 votes), past polls