Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

The two answers above should address the problem you're having. Here are some style tips though...

In these two lines, you are treating $self like it is a hashref...

$self->{tempfile} = File::Temp->new(UNLINK => 1, SUFFIX => '.tmp'); print $self->{tempfile} "I am here";

But self is not a hashref; it's an object. OK, so Moose implements objects as blessed hashrefs by default, but it is considered bad form to treat an object as a hashref - we're supposed to pretend that it's not a hashref, and only access the internals via the accessors that Moose gives us. So we should do this...

$self->tempfile( File::Temp->new(UNLINK => 1, SUFFIX => '.tmp') ); print {$self->tempfile} "I am here";

The reasons for doing so are not just theoretical. Accessing the object as a hashref bypasses all your type constraints, triggers, etc.

Secondly, you are initialising an attribute within the BUILD method. While you can do that, Moose does provide attribute defaults and builders for this sort of thing:

package test; # not '' use Moose; use File::Temp; has tempfile => ( is => 'rw', isa => 'File::Temp', lazy => 1, default => sub { File::Temp->new(UNLINK => 1, SUFFIX => '.tmp') }, ); sub BUILD { my $self = shift; print { $self->tempfile } "I am here"; }
perl -E'sub Monkey::do{say$_,for@_,do{($monkey=[caller(0)]->[3])=~s{::}{ }and$monkey}}"Monkey say"->Monkey::do'

In reply to Re: Moose and File::Temp by tobyink
in thread Moose and File::Temp by gsiglet

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others scrutinizing the Monastery: (8)
    As of 2015-11-28 14:32 GMT
    Find Nodes?
      Voting Booth?

      What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

      Results (742 votes), past polls