Too many curlies. toolic's advice is good, but you can safely remove even more: s/$thing/$translate{$thing}/g;
Be careful, though, if one translation results in a word that another translation might translate again.
Sometimes, avoiding the inner loop by constructing the regex leads to a faster solution:
my $re = join '|', keys %translate;
$re = qr/($re)/;
while (<>) {
s/$re/$translate{$1}/g;
print;
}
You might need to add some \b boundaries to the regex so it does not match in the middle of a word.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|