This is how I would do it. The main changes were:
- Do not declare variables in a wider scope than needed.
- Use lexical filehandles and 3-argument open with or die.
- If you want to output frequencies per file, you have to store them per file. That's why the first key is the filename.
- The line is already in the key, no need to store it again to a value.
- You do not have to initialize the counting hash. Just increment it.
#!/usr/bin/perl
use warnings;
use strict;
my %cnt;
for my $file (glob '*.abc') {
open my $FILE, '<', "$file" or die "$!";
for my $line (grep / FREQ /, <$FILE>) {
$line =~ s/ is begin.*//;
$line =~ s/.* FREQ/FREQ/;
chomp($line);
$cnt{$file}{$line}++;
}
}
for my $file ( keys %cnt) {
for my $line ( keys %{ $cnt{$file} } ) {
print "$file $line $cnt{$file}{$line}\n";
}
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|