- Do not use parse (), use getline ()
- Use a lexical file handle
- Never use an else branch if the if branch ends the enclosing scope (exit, return, die, last, …)
- Use auto_diag
- Use positive logic for validation
# Use auto_diag to see all parsing errors immediately
my $csv = Text::CSV_XS->new ({ binary => 1, auto_diag => 1, allow_whit
+espace => 1 });
open my $fh, "<", $file_to_parse or die "Could not open '$file' $!";
while (my $row = $csv->getline ($fh)) {
# Check first and third field to be numeric only (and not empty)
$row->[0] =~ m/^[0-9]+$/ && $row->[2] =~ m/^[0-9]+$/ or
exit; # wrong format
# THERE CANNOT BE AN ELSE AFTER AN EXIT !
}
update: your sample data contains spaces. You will have to deal with those, as the current tests will fail for leading and training spaces. Adding allow_whitespace option to the constructor will help you here.
Enjoy, Have FUN! H.Merijn
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|