Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

G'day spstansbury,

I see Tux has provided you with a better way to tackle your task. The reason you're getting the results you see with your posted solution is as follows.

Given this test.csv (newlines shown as "$" and tabs as "^I"):

$ cat -vet test.csv quote at end"$ no quote at end$ quote and space at end" $ quote and tab at end"^I$

Your posted code matches every line:

$ perl -ne 'print $_ if $_ =~ /[^"]$/' < test.csv quote at end" no quote at end quote and space at end" quote and tab at end"

The reason for this becomes apparent when you look at exactly what $_ contains:

$ perl -ne 'print ">>>$_<<<\n" if $_ =~ /[^"]$/' < test.csv >>>quote at end" <<< >>>no quote at end <<< >>>quote and space at end" <<< >>>quote and tab at end" <<<

Each line ends with a newline which, not being a double-quote, means /[^"]$/ matches.

You can get around this most easily but simply using the -l switch:

$ perl -lne 'print $_ if $_ =~ /[^"]$/' < test.csv no quote at end quote and space at end" quote and tab at end"

If you look at perlrun, you'll see that's equivalent to chomping each input line and appending a newline (or whatever the current value of $/ is) to each output line:

$ perl -ne 'chomp; print "$_\n" if $_ =~ /[^"]$/' < test.csv no quote at end quote and space at end" quote and tab at end"

[Note: the -l switch is a little more complicated than my simplistic explanation - see the doco for details.]

-- Ken


In reply to Re: Trying to find missing closing quotes in CSV by kcott
in thread Trying to find missing closing quotes in CSV by spstansbury

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others musing on the Monastery: (4)
As of 2024-04-24 03:22 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found