Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

You seem to be confused about references:

$RESULT = &getdata(\%DATA,\%CONFIG,\%STATIC); ##read config-file ... if ($PROTO =~ m/ssh/i){ %DATA = &connect2cpe_SSH(\%DATA,\%CONFIG,\%STATIC); }else{ %DATA = &connect2cpe_TELNET(\%DATA,\%CONFIG,\%STATIC); }

You are calling those functions with references to three hashes but only in getdata() do you actually dereference those hashes:

$STATIC->{$T[0]}=$T[1]; ... $DATA{$IP}->{COMMANDS} = \@COMMANDS; $DATA{$IP}->{MATCHES} = \@MATCHES;

Otherwise you are just modifying the file scoped hashes.

And then for connect2cpe_SSH() and connect2cpe_TELNET() you copy the already modified %DATA back to itself?    Whether you modify %DATA directly or through a reference there is no need to copy it to itself.



if ($#ARGV < 0 ) { &help($0); exit 0;} ... 'help|h' => sub { &help($0); exit 0;} ) || die(&help($0));

help() returns a value but you never use that value so why return it?    You pass the $0 variable to help() but because you import help() into the current program the $0 variable is directly available inside help().    Every time you use help() you exit the program.    Perhaps you should put an exit at the end of the help() subroutine and maybe call it "print_help_and_exit"?


In reply to Re: RFC: beginner level script improvement by jwkrahn
in thread RFC: beginner level script improvement by georgecarlin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others romping around the Monastery: (3)
As of 2024-03-19 10:19 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found