Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
well I'm not too convinced about the cases >= 1e10 ... (shouldn't bugs be catched???)

use strict; use warnings; sub id2p_choroba { my $id = shift or return q(); my $chunk_length = length $id > 6 ? 3 : 2; $id = sprintf '%0' . ($chunk_length * 3) . 'd', $id; my $chunk = ".{$chunk_length}"; my $path = join '/', $id =~ / ^ (.*) ($chunk) ($chunk) $ /xg; return $path; } sub id2p_lanx { my $id = shift or return q(); my ($chunk,$len) = (length $id > 6 ) ? (3,9) : (2,6); my $norm = sprintf "%0${len}d", $id; my $path = join "/", ( $norm =~ m/ ^ (-?\d+) (\d{$chunk}) (\d{$chunk}) $ /x ); # $path ||= '-00/000/001'; # this weirdness is needed if '-?' is mi +ssing return $path; } use Test::More tests => 23; is(id2p_lanx($_), id2p_choroba($_), "id=$_") for q(), 0, 1, 9, 10, 99, 100, 999, 1000, 9999, 10000, 99999, 100000, 999999, 1e6, 1e7-1, 1e7, 1e8-1, 1e8, 1e9, 1e10, 1e11, 1e12;


hmm ... well ... surprisingly now after some modifications my code looks a lot like yours! ;-)

Cheers Rolf

( addicted to the Perl Programming Language)

In reply to Re: Can you make it nicer? by LanX
in thread Can you make it nicer? by choroba

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others cooling their heels in the Monastery: (10)
    As of 2018-03-20 12:21 GMT
    Find Nodes?
      Voting Booth?
      When I think of a mole I think of:

      Results (250 votes). Check out past polls.