Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
Personally i consider it most important to have readable code. It doesn't need to be fancy, but it should be quick to be understood. Sometimes i would rather write 2 or 3 lines more, if it would improve readability.
Keeping the same output format of id2path, i would potentially have written it like this:
sub id2path_new { my ($id) = @_; return '' unless $id; my $path = ''; if ($id >= 1_000_000) { $path = sprintf("%09d", $id); $path =~ s#\A(.*)(...)(...)\z#$1/$2/$3#; } else { $path = sprintf("%06d", $id); $path =~ s#\A(..)(..)(..)\z#$1/$2/$3#; } return $path; }
Note: I know that i could also write the regex using \d and the {3} quantifier, resulting in:
In this case however, i consider the dots to be visually clearer, while having the same effect. Having two hard coded printfs is in my opinion also easier to read than first programmatically creating the sprintf format string.

In reply to Re: Can you make it nicer? by rminner
in thread Can you make it nicer? by choroba

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others scrutinizing the Monastery: (4)
    As of 2015-11-25 06:24 GMT
    Find Nodes?
      Voting Booth?

      What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

      Results (671 votes), past polls