Beefy Boxes and Bandwidth Generously Provided by pair Networks Russ
"be consistent"
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
If you find yourself writing long strings of named variables, particularly if you have to synchronize them between different pieces of code you should use hashes and hash slices.

For instance suppose that somewhere you have:

@fields = qw( viewpositionid institution department confirstname conlastname conemail conphone titleposition posnumbert typeposition programtype dvmonth dvday dvyear edmonth edday edyear numposition numvacunit totsalary budgetsalary statefundsources fedfundsources statebudgetcat priclass subip thetime approved );
Then your loop could be replaced with:
foreach my $rec (@ODB) { chomp($rec); my %db_rec; @db_rec{@fields} = split /\t/, $rec; if ($db_rec{viewpositionid} == $cur_rec{viewpositionid}) { # Replace the existing with the updated. %db_rec = %cur_rec; $cur_rec{sub_ip} = $ENV{REMOTE_ADDR}; $cur_rec{approved} = "No"; } print DATABASE join "\t", @db_rc{@fields}; print DATABASE "\n"; }
which is much clearer, and less error prone. (I would choose easier names to read and also try to lose the flatfile database, but one step at a time...)

The key points here are that people tend to mess up positional logic (computers don't) and you want to try to reduce the number of places that any given item of information (eg what fields appear in what order). Plus losing a ton of globals is generally a Good Thing...

Updated Steve_p - fixed the opening code tag on the second block of code


In reply to Re (tilly) 1: OK... I am confused and lost :( Editing FlatFile by tilly
in thread OK... I am confused and lost :( Editing FlatFile by LostS

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others rifling through the Monastery: (10)
    As of 2014-04-17 23:33 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      April first is:







      Results (459 votes), past polls