If you have a question, please post it to Seekers of Perl Wisdom along with a better description of the problem.
I notice your code has a lot of repetition. Generally, whenever I see repetition in code, that tells me I can probably reduce some of it to a function or iteration:
my %check_oids = (
sysUpTime => '1.3.6.1.2.1.1.3.0',
sysDescr => '1.3.6.1.2.1.1.1.0',
sysObjectID => '1.3.6.1.2.1.1.2.0',
sysContact => '1.3.6.1.2.1.1.4.0',
sysName => '1.3.6.1.2.1.1.5.0',
sysLocation => '1.3.6.1.2.1.1.6.0',
sysServices => '1.3.6.1.2.1.1.7.0',
);
foreach (keys %check_oids) {
my $result = $session->get_request(
-varbindlist => [$check_oids{$_}]
);
if (!defined($result)) {
printf("ERROR: %s.\n", $session->error);
$session->close;
exit 1;
}
printf("%s for host '%s' is %s\n", $_,
$session->hostname, $result->{$check_oids{$_}}
);
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|