Question is: When do you decide that the person is off by a little,and try to give him a hint (retaining the faulty code in his program,that you DO see, but not addressess the problem) and when do you rewrite the code ?
Only rewrite the code when you think you can learn something from doing so. Otherwise just point them in the right direction and allow them to discover the answer for themselves. Either way the other person has the opportunity to learn the same amount.
Consider the (fictitious ;) example of someone who posts code on this site. The code is absolutely horrible, no strict, no warnings, flawed param parsing, doesn't check open calls, and so on. Do you rewrite the code for them? or do you point them to related resources on good coding practices? The only reason I would rewrite the code is that I think I could learn something by doing so. Even so, it could be argued that by posting the code I'd be doing them a disservice, so definately don't spend too much time writing code for them if you won't learn anything from the process.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
Outside of code tags, you may need to use entities for some characters:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||